January 28, 2009

disproving is not fixing

I recently submitted a bug to cake. And, well, I’m a bit dissatissfied with the results.

The ticket here explains the issue.

The jist is there is a bad conditional in the form helper, and i don’t care what the “test” case says its wrong. I went to a lot of trouble finding the source of the problem, more time to write it up, and it is dismissed, when you can plainly see the code is incorrect. unless php changed how its operators worked since the last time i checked (and i’m open to hearing about it if they did). but !== is invalid.

further, I’m working on real data, on a real project, and I’m a real person who went to some lengths to nail the issue down. trusting a test case over that is irresponsible and bordering on stupid, actually.

I grow less and less impressed with the cake community, as with the code base itself.

I can’t specifically say why.. but i don’t get the sense the cake people really care about the people who have to use their tools.

if someone wants to take a stab at what they think this evaluates to, i’m all for it:

if (!array_key_exists('escape', $options) || $options['escape'] !== false) {

aside from the wrongheadedness of the entire conditional which asks first if not something exists then asks if the key doesnt equal false can anyone tell me they’ve ever seen !== used anywhere and what it evaluates to?

how bout using some sense people and evaluating for truths now and then evaluating for not not falses.